Review Request: Provide different maximum file sizes for PreviewJob, dependent on whether a file is local or remote

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3493/#review4965
-----------------------------------------------------------


If there are no objections, I'll commit the patch on Monday the 12th of April.

- Peter


On 2010-04-05 14:05:38, Peter Penz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3493/
> -----------------------------------------------------------
> 
> (Updated 2010-04-05 14:05:38)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Currently PreviewJob uses the same maximum file size for local or remote files. The attached patch improves this, so that it is possible for the user to specify different maximum sizes for local and remote files. The default size for remote files has been set to 0.
> 
> To be discussed: For KDE 4.1 the method
>   static KIO::filesize_t PreviewJob::maximumFileSize();
> has been introduced. Corresponding to lxr.kde.org it is not used at all and I'm wondering, whether it makes sense to offer this method at all. IMO we should either:
> a) Introduce corresponding setter methods too
> b) Just declare this method as deprecated (and remove it in KDE 5)
> 
> Beside the maximumFileSize() detail: Are there any objections to commit the patch?
> 
> 
> This addresses bug 211007.
>     https://bugs.kde.org/show_bug.cgi?id=211007
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1111289 
> 
> Diff: http://reviewboard.kde.org/r/3493/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter
> 
>