Support for nested groups in kconf_update
agateau at kde.org
Tue Apr 6 11:25:53 BST 2010
On 03/04/2010 17:50, Oswald Buddenhagen wrote:
> On Tue, Mar 30, 2010 at 05:36:43PM +0200, Aurélien Gâteau wrote:
>> Can this go in?
> this is huge and i don't know the code, so only some mostly superficial
> comments from me:
> you should probably first commit the coding style cleanup and then
> squash everything else into a second commit.
> in fact, posting it like that in the first place would have made
> reviewing simpler ... if you post a patch series for review, then ensure
> that each changeset is self-contained and correct to your best
> knowledge. nobody wants to see your blunders, write comments about them
> and then notice that you silently fix them in later commits. at least i
> can use my time better.
I see your point. Thanks for giving a look at it. I am going to
consolidate the patches a bit more and send them again.
More information about the kde-core-devel