Support for nested groups in kconf_update
ossi at kde.org
Sat Apr 3 16:50:15 BST 2010
On Tue, Mar 30, 2010 at 05:36:43PM +0200, Aurélien Gâteau wrote:
> Can this go in?
this is huge and i don't know the code, so only some mostly superficial
comments from me:
you should probably first commit the coding style cleanup and then
squash everything else into a second commit.
in fact, posting it like that in the first place would have made
reviewing simpler ... if you post a patch series for review, then ensure
that each changeset is self-contained and correct to your best
knowledge. nobody wants to see your blunders, write comments about them
and then notice that you silently fix them in later commits. at least i
can use my time better.
parseGroupString does no dequoting (printableToString in kconfigini). it
is admittedly unlikely that someone would write transformation rules
involving group names containing "weird" characters, but who knows ...
make at least a FIXME remark.
the KConfigUtils namespace is more of an indicator that something is
missing in kconfig than anything else ...
More information about the kde-core-devel