Review Request: Use Solid for (un)mounting in KDesktopFileActions for /dev/* paths

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1632/#review2394
-----------------------------------------------------------

Ship it!


Looks good (apart from the not-useful isEmpty check on readType, as mentionned on IRC).

Feel free to commit, to trunk.
No backport since this is a new feature.

- David


On 2009-09-17 18:57:55, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1632/
> -----------------------------------------------------------
> 
> (Updated 2009-09-17 18:57:55)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Use Solid for /dev/* paths in KDesktopFileActions. This lets kio_sysinfo pass device path and KDesktopFileActions will offer (un)mount option for that.
> 
> See http://lists.kde.org/?t=125236316600003&r=1&w=2 for details.
> 
> 
> I would like to commit this to both: KDE 4.3 and trunk. Currently it is not possible to easy (un)mount devices (I mean in any way, only DeviceNotifier works) and that will affect openSUSE's and KUbuntu's users.
> Hopefully we will able to release new KDE 4.3 with these patches, so we will strongly improve user experience for many distros.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.3/kdelibs/kio/kio/kfileitemactions.cpp 1023881 
>   /branches/KDE/4.3/kdelibs/kio/kio/kdesktopfileactions.cpp 1023881 
> 
> Diff: http://reviewboard.kde.org/r/1632/diff
> 
> 
> Testing
> -------
> 
> I tested this with kio_sysinfo, works great. I can mount & unmount without problems. Also mounting via DeviceNotifier and ummounting via sysinfo doesn't cause problems.
> 
> Hopefully it doesn't introduce any regressions to desktop files handling, but testing is always welcome.
> 
> 
> Thanks,
> 
> Rafa?
> 
>