kdelibs (tests) doesn't build against qt 4.6.0-tp1

[Thiago Macieira]

Em Quinta-feira 17. Setembro 2009, às 18.09.42, Matthew Woehlke escreveu:
> Thiago Macieira wrote:
> > Here I thought that I had fixed the issue... I'm sorry for being
> > aggressive
> 
> Thanks, I appreciate that. Please also accept my apology for becoming
> so... irate about it.

And please accept mine for being aggressive. It was completely uncalled for.

> > If the issue isn't fixed, someone please send a patch.
> 
> I'd say dfaure is on the right track. But... unless you can drop the
> test from *everywhere*, then I don't think this can be fixed¹.

I need to test the patch with the Qt tests. There are hundreds of them, so it 
takes time.

> Basically, it looks like 4.5.x QtTest/QtTest included the contents of
> qtestmouse.h, and kdevelop was relying on this. Some of the others went
> after deeper headers and so are okay with less changes (e.g. you /did/
> fix kdebase, which went after qtestmouse.h directly), but...
> 
> (¹ By "fixed" I mean so that no source changes are required.)
> 
> That said, I'm looking at qtest_kde.h and thinking that '#define
> QT_GUI_LIB' there is maybe a better fix for KDE. Personally I tend to
> agree with dfaure, this isn't a bad enough SIC to worry about, if the
> change must be made to fix another important bug.

The reason why this happened is because a developer went through all Qt tests 
that linked to QtGui unnecessarily and removed the dependency. However, this 
caused linking errors on Windows with gcc because that platform generates 
symbols unnecessarily.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
      http://qt.nokia.com/qtdevdays2009
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090917/7e1536fd/attachment.sig>