Review Request: Extract the Cursor Theme configuration from the Input (Mouse Config) KCM

Fredrik Höglund fredrik at kde.org
Tue Oct 13 19:21:33 BST 2009


On Tuesday 13 October 2009, Darío Andrés wrote:
> Mh, it is still a bit broken (probably because I didn't moved the
> kcminit code to its own module inside cursortheme). The cursor theme
> changes are applied to some applications, but new applications will
> have the old ones, causing a weird mixup.. I need help with this.

Dario, reviewboard is quite clearly useless for this, because what you
have is one patch which is all minuses and another which is all pluses,
and it's impossible to tell what you've changed and what you've only
moved.

The kcminit function can't be moved over as it is, because it's also
responsible for applying the other settings in the input KCM.

As for newly started apps, they pick up the cursor theme either from
an environment variable or from the X resources property on the root
window. ThemePage::applyTheme() changes the environment by making
a DBUS call to KLauncher, and also uses KRdb to update the X resources.

This doesn't work with apps started from a running Konsole session,
since they will inherit the old environment.

The cursors in running applications are updated by loading each cursor
in the new theme and asking the X server to replace all existing cursors
that have the same name, with the newly loaded cursor.

Regards,
Fredrik





More information about the kde-core-devel mailing list