Review Request: Extract the Cursor Theme configuration from the Input (Mouse Config) KCM

Darío Andrés andresbajotierra at gmail.com
Wed Oct 14 16:05:45 BST 2009


On Tue, Oct 13, 2009 at 3:21 PM, Fredrik Höglund <fredrik at kde.org> wrote:
> On Tuesday 13 October 2009, Darío Andrés wrote:
>> Mh, it is still a bit broken (probably because I didn't moved the
>> kcminit code to its own module inside cursortheme). The cursor theme
>> changes are applied to some applications, but new applications will
>> have the old ones, causing a weird mixup.. I need help with this.
>
> Dario, reviewboard is quite clearly useless for this, because what you
> have is one patch which is all minuses and another which is all pluses,
> and it's impossible to tell what you've changed and what you've only
> moved.
>

I see, in fact most of the changes were moving files around, but I had
to introduce new code to initiate the new KCM.

> The kcminit function can't be moved over as it is, because it's also
> responsible for applying the other settings in the input KCM.
>

Mh, my plan would be splitting the kcminit function in two:
So "kcminit_input" will keep loading mouse specific settings
(acceleration and so on...); and a new "kcminit_cursortheme"
(contained in the cursortheme Kcm dir) will load the cursor theme
settings.

> As for newly started apps, they pick up the cursor theme either from
> an environment variable or from the X resources property on the root
> window. ThemePage::applyTheme() changes the environment by making
> a DBUS call to KLauncher, and also uses KRdb to update the X resources.
>
> This doesn't work with apps started from a running Konsole session,
> since they will inherit the old environment.
>

Oh, so that was the thing that confused me.. launching applications
from an already open Konsole showed the old cursors.. I thought I had
broke the code :-\

> The cursors in running applications are updated by loading each cursor
> in the new theme and asking the X server to replace all existing cursors
> that have the same name, with the newly loaded cursor.
>
> Regards,
> Fredrik
>
>

I will polish my implementation and try to send the changes proposal
(svn status and svn diff?) to the ML ...
Thanks for your help!

Regards

Darío A. (bugs.kde.org)




More information about the kde-core-devel mailing list