Review Request: Extract the Cursor Theme configuration from the Input (Mouse Config) KCM

[Darío Andrés]

2009/10/11 Darío Andrés <andresbajotierra at gmail.com>:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1832/
> -----------------------------------------------------------
>
> (Updated 2009-10-12 01:19:50.361649)
>
>
> Review request for kdelibs.
>
>
> Summary (updated)
> -------
>
> This is a simple extraction/split up of the cursor theme configuration from the Input KCM. I copied(moved) most of the code.
> I only added the KCM main source file with all the copyrights from the Input KCM "mouse.h" and "mouse.cpp" files.
> The next steps is remove all the files that this module includes from the Input module (that would be another review request/patch)
>
> This split up is required in our plan of SystemSettings reorganization. In case that the "big reorganization" is not done, we are going to move this new module to "Appearance" as most of the users thinks that is the proper place to find the mouse cursor theme config.
>
> Regards
>
> --
>
> The .desktop file still points to the "keyboard-and-mouse" category. We should redefine that place after the discussion.
>
> While the diff here doesn't show the file moves properly, I have a full copy in my local build (with full svn history)
>
> Oh, I forgot to append the Messages.sh file here, but it is in my local copy too.
> It seems I also forgot to move the kcminit "main.cpp" file...


Mh, it is still a bit broken (probably because I didn't moved the
kcminit code to its own module inside cursortheme). The cursor theme
changes are applied to some applications, but new applications will
have the old ones, causing a weird mixup.. I need help with this.

Regards

>
>
> Diffs
> -----
>
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/CMakeLists.txt 1033579
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/CMakeLists.txt PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/core/bitmaps.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/core/themepage.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/core/themepage.cpp PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/cursor_large.bdf PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/cursor_large_black.pcf.gz UNKNOWN
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/cursor_large_white.pcf.gz UNKNOWN
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/cursor_small_white.pcf.gz UNKNOWN
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/cursortheme.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/cursortheme.cpp PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/cursortheme.desktop PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/kapplymousetheme.cpp PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/mouse_cursor_theme.upd PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/bitmaps.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/cursortheme.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/cursortheme.cpp PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/itemdelegate.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/itemdelegate.cpp PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/legacytheme.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/legacytheme.cpp PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/previewwidget.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/previewwidget.cpp PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/sortproxymodel.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/sortproxymodel.cpp PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/thememodel.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/thememodel.cpp PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/themepage.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/themepage.cpp PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/themepage.ui PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/xcursortheme.h PRE-CREATION
>  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/cursortheme/xcursor/xcursortheme.cpp PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1832/diff
>
>
> Testing
> -------
>
> The module is compiled, and it works properly. The helper tool to apply the theme is working too.
>
>
> Thanks,
>
> Darío
>
>