Review Request: types.cpp:39: warning: comparison between signed and unsigned integer expressions

Guy Maurel guy-kde at maurel.de
Mon Oct 12 19:05:37 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1836/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdelibs/kjs/bytecode/generator/types.cpp:39: warning: comparison between signed and unsigned integer expressions

at
static unsigned neededBits(unsigned vals)

my proposal: make a static_cast
see: types-gm-7.diff


Diffs
-----

  /trunk/KDE/kdelibs/kjs/bytecode/generator/types.cpp 1033934 

Diff: http://reviewboard.kde.org/r/1836/diff


Testing
-------


Thanks,

Guy





More information about the kde-core-devel mailing list