Review Request: types.cpp:39: warning: comparison between signed and unsigned integer expressions

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1836/#review2625
-----------------------------------------------------------


As somebody else already suggested, use

    while ((1U << bits) < vals)

- David


On 2009-10-12 18:05:37, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1836/
> -----------------------------------------------------------
> 
> (Updated 2009-10-12 18:05:37)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdelibs/kjs/bytecode/generator/types.cpp:39: warning: comparison between signed and unsigned integer expressions
> 
> at
> static unsigned neededBits(unsigned vals)
> 
> my proposal: make a static_cast
> see: types-gm-7.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kjs/bytecode/generator/types.cpp 1033934 
> 
> Diff: http://reviewboard.kde.org/r/1836/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>