Review Request: Remove the Cursor Theme handling from the Input (mouse settings) KCM

Darío Andrés andresbajotierra at gmail.com
Mon Oct 12 01:47:32 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1833/
-----------------------------------------------------------

(Updated 2009-10-12 00:47:32.327757)


Review request for kdelibs.


Summary
-------

This is the second part of http://reviewboard.kde.org/r/1832/
As I extracted the code from the Cursor Theme configuration from the Input KCM into its own KCM then this patch removes the cursor theme handling leftovers from the Input KCM.
The patch is just about file deletion and minor changes in "mouse.cpp" and "mouse.h" to not include the "Theme" tab.
As I removed some binary files too I don't know if reviewboard shows them...

While the diff here doesn't show the file moves properly, I have a full copy in my local build (with full svn history)


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/CMakeLists.txt 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/core/bitmaps.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/core/themepage.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/core/themepage.cpp 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/cursor_large.bdf UNKNOWN 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/cursor_large_black.pcf.gz UNKNOWN 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/cursor_large_white.pcf.gz UNKNOWN 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/cursor_small_white.pcf.gz UNKNOWN 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/kapplymousetheme.cpp 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/mouse.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/mouse.cpp 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/mouse_cursor_theme.upd 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/bitmaps.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/cursortheme.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/cursortheme.cpp 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/itemdelegate.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/itemdelegate.cpp 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/legacytheme.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/legacytheme.cpp 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/previewwidget.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/previewwidget.cpp 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/sortproxymodel.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/sortproxymodel.cpp 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/thememodel.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/thememodel.cpp 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/themepage.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/themepage.cpp 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/themepage.ui 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/xcursortheme.h 1034090 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/input/xcursor/xcursortheme.cpp 1034090 

Diff: http://reviewboard.kde.org/r/1833/diff


Testing
-------

It compiles and works properly


Thanks,

Darío





More information about the kde-core-devel mailing list