Review Request: function.cpp: 290: comparison between signed and unsigned integer expressions

[Maksim Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1828/#review2614
-----------------------------------------------------------


Why not just change the signature and adjust the caller? This isn't a public API.

- Maksim


On 2009-10-11 16:13:56, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1828/
> -----------------------------------------------------------
> 
> (Updated 2009-10-11 16:13:56)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The kdelibs-Dashboard reports:
> /.../kdelibs/kjs/function.cpp:290: warning: comparison between signed and unsigned integer expressions
> 
> at the line
> Identifier FunctionImp::getParameterName(int index)
> 
> my proposal ist to introduce a local variable, make a proper definition of pos
> see the attachted patch.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kjs/function.cpp 1033934 
> 
> Diff: http://reviewboard.kde.org/r/1828/diff
> 
> 
> Testing
> -------
> 
> at home
> 
> 
> Thanks,
> 
> Guy
> 
>