Review Request: function.cpp: 290: comparison between signed and unsigned integer expressions

Guy Maurel guy-kde at maurel.de
Sun Oct 11 17:13:56 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1828/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The kdelibs-Dashboard reports:
/.../kdelibs/kjs/function.cpp:290: warning: comparison between signed and unsigned integer expressions

at the line
Identifier FunctionImp::getParameterName(int index)

my proposal ist to introduce a local variable, make a proper definition of pos
see the attachted patch.


Diffs
-----

  /trunk/KDE/kdelibs/kjs/function.cpp 1033934 

Diff: http://reviewboard.kde.org/r/1828/diff


Testing
-------

at home


Thanks,

Guy





More information about the kde-core-devel mailing list