Review Request: Automatic AdBlock filter list updates in Konqueror

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2265/#review3350
-----------------------------------------------------------



/trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp
<http://reviewboard.kde.org/r/2265/#comment2690>

    Just a thought: wouldn't it be simpler to use one (nested) KConfigGroup per value of i? Then the keys would stay constant. No big deal though.



/trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp
<http://reviewboard.kde.org/r/2265/#comment2691>

    KConfig supports bools, you can remove the ?"true":"false" bit.



/trunk/KDE/kdelibs/khtml/khtml_settings.cpp
<http://reviewboard.kde.org/r/2265/#comment2688>

    To remove a local file, use QFile::remove().
    
    NetAccess::del opens a local event loop which can trigger all sort of issues.



/trunk/KDE/kdelibs/khtml/khtml_settings.cpp
<http://reviewboard.kde.org/r/2265/#comment2689>

    Please use KIO::get instead of NetAccess::download. Which means moving the rest of the code to a slot, but I guess that's not a big problem here.


- David


On 2009-11-22 20:30:34, Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2265/
> -----------------------------------------------------------
> 
> (Updated 2009-11-22 20:30:34)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is the patch from bug report 143495 slightly rewritten to fit KDE trunk (though not compiled as I am lacking Qt 4.6). The original patch was written for 4.2.4, later updated for 4.3.1. Please refer to the bug report in bugs.kde.org for a small history of this patch set.
> I wrote a blog entry explaining the background of this patch, too: http://blog.t-fischer.net/2009/08/05/automatic-adblock-filter-list-updates-in-konqueror/
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.h 1052921 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp 1052921 
>   /trunk/KDE/kdelibs/khtml/khtml_settings.cpp 1052921 
> 
> Diff: http://reviewboard.kde.org/r/2265/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
>