Review Request: Automatic AdBlock filter list updates in Konqueror

[Thomas Fischer]

> On 2009-11-23 09:31:00, Stefan Majewsky wrote:
> > I'm not a KHTML dev and can not comment on the code, but from what I see, you do not predefine any filter list providers, so this feature is hardly usable for novice users. Is there any filter list provider that allows us to use his list as a default in Konqueror?

Yes, a default list of filter URLs is provided in an example file in the original bug report. See this attachment: http://bugsfiles.kde.org/attachment.cgi?id=35778
KHTML's filter code looks as it was tailored to the EasyList format, although KHTML does not support all features.
Therefore, by default my code (and the example khtmlrc file) simply use the current blocking lists available for download from the EasyList website. I am not aware of other filter list collections using the same format.
I am not sure about the best way of providing this list. Either put it into source code to be written and used as a default set or provide a file to be installed in the system or personal configuration folders.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2265/#review3235
-----------------------------------------------------------


On 2009-11-22 20:30:34, Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2265/
> -----------------------------------------------------------
> 
> (Updated 2009-11-22 20:30:34)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is the patch from bug report 143495 slightly rewritten to fit KDE trunk (though not compiled as I am lacking Qt 4.6). The original patch was written for 4.2.4, later updated for 4.3.1. Please refer to the bug report in bugs.kde.org for a small history of this patch set.
> I wrote a blog entry explaining the background of this patch, too: http://blog.t-fischer.net/2009/08/05/automatic-adblock-filter-list-updates-in-konqueror/
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.h 1052921 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp 1052921 
>   /trunk/KDE/kdelibs/khtml/khtml_settings.cpp 1052921 
> 
> Diff: http://reviewboard.kde.org/r/2265/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
>