Review Request: Automatic AdBlock filter list updates in Konqueror

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2265/#review3352
-----------------------------------------------------------


Nice (but obviously not for 4.4 due to the feature freeze, it will have to be for 4.5)


/trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp
<http://reviewboard.kde.org/r/2265/#comment2693>

    NULL is the default value for toInt(), no need to write it explicitely.



/trunk/KDE/kdelibs/khtml/khtml_settings.cpp
<http://reviewboard.kde.org/r/2265/#comment2694>

    use !line.isEmpty() rather than comparing with the null string.



/trunk/KDE/kdelibs/khtml/khtml_settings.cpp
<http://reviewboard.kde.org/r/2265/#comment2695>

    since line is not empty here, it might be simpler and faster to just have a local 
    const QChar firstChar = line.at(0);
    and compare that with all these chars.


- David


On 2009-11-22 20:30:34, Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2265/
> -----------------------------------------------------------
> 
> (Updated 2009-11-22 20:30:34)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is the patch from bug report 143495 slightly rewritten to fit KDE trunk (though not compiled as I am lacking Qt 4.6). The original patch was written for 4.2.4, later updated for 4.3.1. Please refer to the bug report in bugs.kde.org for a small history of this patch set.
> I wrote a blog entry explaining the background of this patch, too: http://blog.t-fischer.net/2009/08/05/automatic-adblock-filter-list-updates-in-konqueror/
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.h 1052921 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp 1052921 
>   /trunk/KDE/kdelibs/khtml/khtml_settings.cpp 1052921 
> 
> Diff: http://reviewboard.kde.org/r/2265/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
>