Review Request: Let KIO::ForwardingSlaveBase emit default errors in case rewriteUrl fails

[Sebastian Trueg]

> On 2009-11-20 15:36:40, Kevin Ottens wrote:
> > Looks fine to me.
> > Just please address formatting first: "} else ..." (no new line after the }). Then it's ok to go.

Hm, but the code does not follow the kdelibs style guidelines at all. It actually uses newlines before all the brackets. Should I correct all of them? Probably not, right?


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2207/#review3184
-----------------------------------------------------------


On 2009-11-18 20:19:39, Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2207/
> -----------------------------------------------------------
> 
> (Updated 2009-11-18 20:19:39)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> All my KIO slaves are based on ForwardingSlaveBase. Some operations are not supported for certain URLs. In this case rewriteUrl simply returns false. In order not to implement each check in every method again having ForwardSlaveBase take care of the error emitting makes life a lot easier.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/forwardingslavebase.cpp 1050786 
> 
> Diff: http://reviewboard.kde.org/r/2207/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>