Review Request: Let KIO::ForwardingSlaveBase emit default errors in case rewriteUrl fails

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2207/#review3184
-----------------------------------------------------------

Ship it!


Looks fine to me.
Just please address formatting first: "} else ..." (no new line after the }). Then it's ok to go.

- Kevin


On 2009-11-18 20:19:39, Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2207/
> -----------------------------------------------------------
> 
> (Updated 2009-11-18 20:19:39)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> All my KIO slaves are based on ForwardingSlaveBase. Some operations are not supported for certain URLs. In this case rewriteUrl simply returns false. In order not to implement each check in every method again having ForwardSlaveBase take care of the error emitting makes life a lot easier.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/forwardingslavebase.cpp 1050786 
> 
> Diff: http://reviewboard.kde.org/r/2207/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>