Review Request: Let KIO::ForwardingSlaveBase emit default errors in case rewriteUrl fails

[Kevin Ottens]

On Saturday 21 November 2009 13:08:53 Sebastian Trueg wrote:
> > On 2009-11-20 15:36:40, Kevin Ottens wrote:
> > > Looks fine to me.
> > > Just please address formatting first: "} else ..." (no new line after
> > > the }). Then it's ok to go.
> 
> Hm, but the code does not follow the kdelibs style guidelines at all. It
>  actually uses newlines before all the brackets.

Because it was written before the guidelines were set.

> Should I correct all of them? Probably not, right?

Nope, just stick to the style for new or modified code.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud patron of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091124/515d7a2f/attachment.sig>