Review Request: Let KIO::ForwardingSlaveBase emit default errors in case rewriteUrl fails

Sebastian Trueg trueg at kde.org
Wed Nov 18 20:19:40 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2207/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

All my KIO slaves are based on ForwardingSlaveBase. Some operations are not supported for certain URLs. In this case rewriteUrl simply returns false. In order not to implement each check in every method again having ForwardSlaveBase take care of the error emitting makes life a lot easier.


Diffs
-----

  trunk/KDE/kdelibs/kio/kio/forwardingslavebase.cpp 1050786 

Diff: http://reviewboard.kde.org/r/2207/diff


Testing
-------


Thanks,

Sebastian





More information about the kde-core-devel mailing list