Used but never set HAVE_FOO macros
winter at kde.org
Sat Mar 21 15:19:28 GMT 2009
On Saturday 21 March 2009 10:29:21 am Allen Winter wrote:
> Based on a discussion in the buildsystem mailing list, I am looking
> for HAVE_FOO macros we are using in our code, but not setting
> anywhere in the buildsystem.
> For kdeilbs, I found the following.
> fix the code;
> make a CMake check for the feature;
> or tell me I have false positive in my checker program
> kinit/proctitle.cpp: HAVE___PROGNAME, HAVE___PROGNAME_FULL, HAVE____PROGNAME_FULL
False positive for HAVE__PROGNAME and HAVE__PROGNAME_FULL. I fixed my checker.
However, there is a HAVE____PROGNAME_FULL used in proctitle.cpp that I don't
set anywhere. Definitely looks like an extra underscore. I hope someone
who knows this code will take a look.
> khtml/misc/borderarcstroker.cpp: HAVE_SSE
False positive. I'll fix.
> kdecore/network/k3socketdevice.cpp: HAVE_SYS_SELECT
I fixed this. should have been HAVE_SYS_SELECT_H
Allen Winter | Software Engineer | 1-888-872-9339
KDAB, Inc. | "Platform-independent software solutions"
http://kdab.com | 1-866-777-5322 (US) | +46-563-540090 (Sweden)
More information about the kde-core-devel