Review Request: fix a memory leak in ktip

Michael Pyne mpyne at kde.org
Fri Jul 24 22:34:55 BST 2009


On Friday 24 July 2009 15:22:22 Chani wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1118/#review1744
> -----------------------------------------------------------
>
> Ship it!
>
>
>
> /trunk/KDE/kdelibs/kdeui/dialogs/ktip.cpp
> <http://reviewboard.kde.org/r/1118/#comment1137>
>
>     it's called Private, it's defined in the cpp file not a .h - it's
> private API. :) that means you don't have to worry about BC requirements.
> I'm not actually sure whether adding a destructor is BC...

I *think* it is BC as if the destructor is virtual then it should already have 
an entry in the vtable, and if the destructor is non-virtual then it's not a 
concern.

Of course it doesn't matter here anyways.

Regards,
 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090724/d07f7c8a/attachment.sig>


More information about the kde-core-devel mailing list