Review Request: fix a memory leak in ktip

Chani chanika at gmail.com
Fri Jul 24 20:22:22 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1118/#review1744
-----------------------------------------------------------

Ship it!



/trunk/KDE/kdelibs/kdeui/dialogs/ktip.cpp
<http://reviewboard.kde.org/r/1118/#comment1137>

    it's called Private, it's defined in the cpp file not a .h - it's private API. :) that means you don't have to worry about BC requirements.
    I'm not actually sure whether adding a destructor is BC...


- Chani


On 2009-07-24 18:35:27, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1118/
> -----------------------------------------------------------
> 
> (Updated 2009-07-24 18:35:27)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Remove a memory leak of 4,260 (8 direct, 4,252 indirect) bytes in 1 blocks are definitely lost.
> This does not change the ABI, isn't it?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/dialogs/ktip.cpp 1001927 
> 
> Diff: http://reviewboard.kde.org/r/1118/diff
> 
> 
> Testing
> -------
> 
> run valgrind with two kde apps with tips.
> 
> 
> Thanks,
> 
> Jaime
> 
>





More information about the kde-core-devel mailing list