[PATCH] Add support for JEDEC/metric standards to KLocale::formatByteSize
mpyne at kde.org
Sun Jul 12 19:51:42 BST 2009
On Sunday 12 July 2009 14:23:17 Marcel Partap wrote:
> > So, I’d ask the KDE developer to *please* clean up this mess.
> > Follow SI consistently. Preferably also use kibi and mebi units instead
> > kilo and mega units (exceptions where decimal units are ‘standard’ is
> > OK).
> > And if possible, please include comments with each string showing that
> > you have done so (example: ‘Note: MiB = 1024 × 1024 bytes’, ‘Note: b =
> > bit’, ‘Note: B = byte’, ’Note: kb/s = 1000 bits per second’), so we
> > don’t have to double-check the source code to ensure the author got it
> > right.
> Personally i also am against introducing the non-sensical and outdated
> JEDEC standard and think my patch, which Michael also was referring to,
> provides the interface needed to suit the needs of users and translators.
Your patch will need revised to account for recent performance improvement
changes (grep for CACHEBYTEFMT in klocale.cpp) if it hasn't already.
> Please have a look at it over at http://reviewboard.kde.org/r/943/diff,
I tried to look at it last week (and had to instead consult your patch from
February) but it still comes up with a Python traceback (and before that,
simply came up with nothing). It's probably a Reviewboard bug but you'll
probably need to re-submit it to reviewboard I think.
- Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel