Review Request: Fix description handling in Places entry editor

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1312/#review2089
-----------------------------------------------------------

Ship it!


Thanks for the improvements. Good to go now IMO.

- Kevin


On 2009-08-19 23:16:17, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1312/
> -----------------------------------------------------------
> 
> (Updated 2009-08-19 23:16:17)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Summary
> -------
> 
> This fixes a few problems with the "Description" of file places:
> 
> * it says "Description", but you are not going to enter a description, but only a (descriptive) label
> * the "Enter description here" is not a clickMessage, but the actual default text
> * due to setting this, automatic derivation of label from URL does not work as intended
> * label derivation from URL fails for URLs without path or host (e.g. "ftp://ftp.test.org/", "music://")
> 
> Please also review string changes.
> 
> 
> This addresses bug 159971.
>     https://bugs.kde.org/show_bug.cgi?id=159971
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kfileplacesview.cpp 1013177 
>   /trunk/KDE/kdelibs/kfile/kfileplaceeditdialog.cpp 1013177 
>   /trunk/KDE/kdelibs/kfile/kfileplaceeditdialog.h 1013177 
> 
> Diff: http://reviewboard.kde.org/r/1312/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
>