Review Request: Fix description handling in Places entry editor

Christoph Feck christoph at
Thu Aug 20 00:16:17 BST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-08-19 23:16:17.023426)

Review request for Dolphin and kdelibs.


* renamed "description" to "label" in code. As the class is internal (not exported), I also renamed the accessor function. I hope this is okay.
* renamed "m_edit" to "m_labelEdit"
* white space changes, as requested


This fixes a few problems with the "Description" of file places:

* it says "Description", but you are not going to enter a description, but only a (descriptive) label
* the "Enter description here" is not a clickMessage, but the actual default text
* due to setting this, automatic derivation of label from URL does not work as intended
* label derivation from URL fails for URLs without path or host (e.g. "", "music://")

Please also review string changes.

This addresses bug 159971.

Diffs (updated)

  /trunk/KDE/kdelibs/kfile/kfileplacesview.cpp 1013177 
  /trunk/KDE/kdelibs/kfile/kfileplaceeditdialog.cpp 1013177 
  /trunk/KDE/kdelibs/kfile/kfileplaceeditdialog.h 1013177 





More information about the kde-core-devel mailing list