Review Request: Add global option to turn off "natural sorting" of user visible strings.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1350/#review2083
-----------------------------------------------------------


The discussion has turned into off-topic base-36 sorting IMHO; this isn't what this review request was about.
I agree with this global option.

Missing @since 4.4 in the kglobalsettings.h method.

Also missing: the handling of the notification that the setting has changed, you can't really tell people to restart dolphin or kde after changing the setting. KGlobalSettings has support for emitting signals on change, you just have to pick an appropriate signal or add one (see also the ChangeType enum), call emitChange from the KCM, and connect to the signal in the kfile code.

- David


On 2009-08-17 22:01:34, Peter Penz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1350/
> -----------------------------------------------------------
> 
> (Updated 2009-08-17 22:01:34)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Corresponding to https://bugs.kde.org/show_bug.cgi?id=169883 some people like to disable the "natural sorting" (http://sourcefrog.net/projects/natsort) of user visible strings in Dolphin, Konqueror, the file dialog, ... so that instead of:
> 
> image 1.jpg
> image 2.jpg
> image 10.jpg
> image 11.jpg
> 
> (= natural sorting)
> 
> strings are sorted by their unicode values like when doing an ls:
> image 10.jpg
> image 11.jpg
> image 1.jpg
> image 2.jpg
> 
> This makes sense especially if people have named their directories and files before "natural sorting" was default (it got default since KDE 4.0). In opposite to other sort properties like "Ascending", "Folder First", "By Name|Size|Date|..." I don't see this as a property that can be remembered per directory, but as a global setting. I also doubt that the majority of our users care about turning off the "natural sorting" ("natural sorting" is default on Windows since XP and also default on Mac OS X's Finder); so I'd prefer _not_ offering a menu entry checkbox "[x] Natural Sorting" beside the other sorting properties as I'm sure only ver less people know what "natural sorting" means. Instead I'd like to add an advanced UI option in the Dolphin settings dialog or a kcm module that adjusts this global setting (the location of the UI option has not been decided yet, I'd first need the OK that a global setting makes sense for everybody). Any opinions?
> 
> 
> This addresses bug 169883.
>     https://bugs.kde.org/show_bug.cgi?id=169883
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.h 1012603 
>   trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp 1012603 
>   trunk/KDE/kdelibs/kfile/kdirsortfilterproxymodel.cpp 1012603 
> 
> Diff: http://reviewboard.kde.org/r/1350/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter
> 
>