Review Request: Add global option to turn off "natural sorting" of user visible strings.

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1350/
-----------------------------------------------------------

(Updated 2009-08-19 12:01:10.250627)


Review request for kdelibs.


Changes
-------

Thanks David for the review, I've fixed your findings and have tested the code with a temporary (?) settings code in Dolphin.

Not directly related to the patch for kdelibs: I'm unsure where the user interface option for this setting should be located. I could not find a proper place in a kcm for system settings and have temporary added a checkbox in Dolphin -> General -> Behavior. Any suggestions for better locations would be welcome.


Summary
-------

Corresponding to https://bugs.kde.org/show_bug.cgi?id=169883 some people like to disable the "natural sorting" (http://sourcefrog.net/projects/natsort) of user visible strings in Dolphin, Konqueror, the file dialog, ... so that instead of:

image 1.jpg
image 2.jpg
image 10.jpg
image 11.jpg

(= natural sorting)

strings are sorted by their unicode values like when doing an ls:
image 10.jpg
image 11.jpg
image 1.jpg
image 2.jpg

This makes sense especially if people have named their directories and files before "natural sorting" was default (it got default since KDE 4.0). In opposite to other sort properties like "Ascending", "Folder First", "By Name|Size|Date|..." I don't see this as a property that can be remembered per directory, but as a global setting. I also doubt that the majority of our users care about turning off the "natural sorting" ("natural sorting" is default on Windows since XP and also default on Mac OS X's Finder); so I'd prefer _not_ offering a menu entry checkbox "[x] Natural Sorting" beside the other sorting properties as I'm sure only ver less people know what "natural sorting" means. Instead I'd like to add an advanced UI option in the Dolphin settings dialog or a kcm module that adjusts this global setting (the location of the UI option has not been decided yet, I'd first need the OK that a global setting makes sense for everybody). Any opinions?


This addresses bug 169883.
    https://bugs.kde.org/show_bug.cgi?id=169883


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.h 1012603 
  /trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp 1012603 
  /trunk/KDE/kdelibs/kfile/kdirsortfilterproxymodel.h 1012603 
  /trunk/KDE/kdelibs/kfile/kdirsortfilterproxymodel.cpp 1012603 

Diff: http://reviewboard.kde.org/r/1350/diff


Testing (updated)
-------

Tested with temporary (?) settings code in Dolphin.


Thanks,

Peter