Review Request: Remove some warnings when compiled with: ADD_DEFINITIONS( -Wall -Wextra -Weffc++ -Wstrict-null-sentinel -Wabi -Wreorder -Woverloaded-virtual)

[Rafael Fernández]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1327/#review2040
-----------------------------------------------------------



/trunk/KDE/kdelibs/kdecore/compression/kfilterdev.cpp
<http://reviewboard.kde.org/r/1327/#comment1365>

    I don't see the need of initializing here buffer(), origFileName(), result() and filter().
    
    buffer(), origFileName() and result() default constructors are being called anyways, and filter is being initialized on the KFilterDev ctr, so if you want you could do on the Private ctr filter(0) but anyways... I don't see the need for this...
    
    Is this actually removing any warnings ?


- Rafael


On 2009-08-15 12:36:53, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1327/
> -----------------------------------------------------------
> 
> (Updated 2009-08-15 12:36:53)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Remove some warnings when compiled with: ADD_DEFINITIONS( -Wall -Wextra -Weffc++ -Wstrict-null-sentinel -Wabi -Wreorder -Woverloaded-virtual)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/compression/kfilterdev.cpp 1011431 
>   /trunk/KDE/kdelibs/kdecore/compression/kgzipfilter.cpp 1011431 
> 
> Diff: http://reviewboard.kde.org/r/1327/diff
> 
> 
> Testing
> -------
> 
> Compiles with less warnings and konqueror works with gzipped http content.
> 
> 
> Thanks,
> 
> Jaime
> 
>