Review Request: Remove some warnings when compiled with: ADD_DEFINITIONS( -Wall -Wextra -Weffc++ -Wstrict-null-sentinel -Wabi -Wreorder -Woverloaded-virtual)

Thiago Macieira thiago at
Sun Aug 16 08:25:18 BST 2009

Rafael Fernández wrote:
>    buffer(), origFileName() and result() default constructors are being
> called anyways, and filter is being initialized on the KFilterDev ctr,
> so if you want you could do on the Private ctr filter(0) but anyways...
> I don't see the need for this... 
>    Is this actually removing any warnings ?

-Weffc++ produces too many warnings to be useful. Forget it.

Thiago Macieira - thiago (AT) - thiago (AT)
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the kde-core-devel mailing list