Review Request: Remove some warnings when compiled with: ADD_DEFINITIONS( -Wall -Wextra -Weffc++ -Wstrict-null-sentinel -Wabi -Wreorder -Woverloaded-virtual)
Michael Pyne
mpyne at kde.org
Sun Aug 16 01:22:30 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1327/#review2039
-----------------------------------------------------------
/trunk/KDE/kdelibs/kdecore/compression/kgzipfilter.cpp
<http://reviewboard.kde.org/r/1327/#comment1364>
You should use false instead of 0 for the bool members here.
- Michael
On 2009-08-15 12:36:53, Jaime Torres wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1327/
> -----------------------------------------------------------
>
> (Updated 2009-08-15 12:36:53)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Remove some warnings when compiled with: ADD_DEFINITIONS( -Wall -Wextra -Weffc++ -Wstrict-null-sentinel -Wabi -Wreorder -Woverloaded-virtual)
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdecore/compression/kfilterdev.cpp 1011431
> /trunk/KDE/kdelibs/kdecore/compression/kgzipfilter.cpp 1011431
>
> Diff: http://reviewboard.kde.org/r/1327/diff
>
>
> Testing
> -------
>
> Compiles with less warnings and konqueror works with gzipped http content.
>
>
> Thanks,
>
> Jaime
>
>
More information about the kde-core-devel
mailing list