Review Request: Forwarding headers for Kross

Ben Boeckel MathStuf at gmail.com
Wed Aug 12 23:58:55 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sebastian Sauer wrote:

> Ben Boeckel wrote:
>> Summary
>> -------
>> 
>> Kross does not currently provide the forwarding headers 
(#include
>> [Kross/ClassName] (angle brackets aren't being escaped?)). 
This patch adds
>> headers for the public classes as well as the install command 
to the
>> CMakeLists.txt.
> 
> I would say "Ship it" but...
>  
>> Testing
>> -------
>> 
>> None right now, though the headers are trivial. I'm still 
working to get a
>> setup for tracking trunk.
> 
> The patch does not apply clean in trunk and merging manual 
results in a 
> 
> CMake Error at cmake_install.cmake:44 (FILE):
>   file INSTALL cannot find file
>   "/home/kde/svn/trunk/KDE/kdelibs/Kross/Action" to install.
> 
> Looks as s/Kross/kross/ (case sensitive) may help.
Yeah... Try -p0 with patch. That made it apply here. Otherwise 
it seems as though it ignored the paths in the hunk headers.

- --Ben
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqDSTMACgkQiPi+MRHG3qQ2+ACfWjHBSFX7zxXI8igSSkYRpykY
m3MAn1ub+ENqHIyFJb9dQCPnyuXU0xqO
=Lwhl
-----END PGP SIGNATURE-----






More information about the kde-core-devel mailing list