Review Request: Forwarding headers for Kross

Sebastian Sauer mail at dipe.org
Thu Aug 13 00:35:11 BST 2009


Ben Boeckel wrote:
> Summary
> -------
> 
> Kross does not currently provide the forwarding headers (#include
> [Kross/ClassName] (angle brackets aren't being escaped?)). This patch adds
> headers for the public classes as well as the install command to the
> CMakeLists.txt.

I would say "Ship it" but...
 
> Testing
> -------
> 
> None right now, though the headers are trivial. I'm still working to get a
> setup for tracking trunk.

The patch does not apply clean in trunk and merging manual results in a 

CMake Error at cmake_install.cmake:44 (FILE):
  file INSTALL cannot find file
  "/home/kde/svn/trunk/KDE/kdelibs/Kross/Action" to install.

Looks as s/Kross/kross/ (case sensitive) may help.




More information about the kde-core-devel mailing list