Review Request: Allow the use of KModifierKeyInfo in contexts without KApplication

Michael Leupold lemma at confuego.org
Mon Aug 10 13:11:30 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/930/
-----------------------------------------------------------

(Updated 2009-08-10 12:11:30.742952)


Review request for kdelibs.


Changes
-------

Fix the previous patch - removing eventfilters is not supported, so just set it to disabled and directly bypass to the previous filter.

Could someone with event dispatcher experience please review this?


Summary
-------

Currently KModifierKeyInfo needs a KApplication to install the event filter and dumps a warning if it isn't available. This patch makes it possible to use it in QApplication-only apps (eg. kdm) by installing the event filter using QAbstractEventDispatcher.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/util/kmodifierkeyinfoprovider_p.h 1008830 
  /trunk/KDE/kdelibs/kdeui/util/kmodifierkeyinfoprovider_x11.cpp 1008830 

Diff: http://reviewboard.kde.org/r/930/diff


Testing
-------


Thanks,

Michael





More information about the kde-core-devel mailing list