Review Request: Allow the use of KModifierKeyInfo in contexts without KApplication

Michael Leupold lemma at confuego.org
Sun Aug 2 00:46:20 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/930/#review1879
-----------------------------------------------------------



/trunk/KDE/kdelibs/kdeui/util/kmodifierkeyinfoprovider_x11.cpp
<http://reviewboard.kde.org/r/930/#comment1225>

    I'm not sure if that's the way to do it. It seems it might wreak havoc if were're in the middle of an event-handler chain.


- Michael


On 2009-07-03 03:05:59, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/930/
> -----------------------------------------------------------
> 
> (Updated 2009-07-03 03:05:59)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Currently KModifierKeyInfo needs a KApplication to install the event filter and dumps a warning if it isn't available. This patch makes it possible to use it in QApplication-only apps (eg. kdm) by installing the event filter using QAbstractEventDispatcher.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/util/kmodifierkeyinfoprovider_p.h 990759 
>   /trunk/KDE/kdelibs/kdeui/util/kmodifierkeyinfoprovider_x11.cpp 990759 
> 
> Diff: http://reviewboard.kde.org/r/930/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>





More information about the kde-core-devel mailing list