branches/KDE/4.2/kdelibs/plasma [BIC]

[Dan Meltzer]

On Wed, Apr 29, 2009 at 1:26 PM, Alexander Neundorf <neundorf at kde.org> wrote:
> On Wednesday 29 April 2009, Jacopo De Simoi wrote:
>> Hi
>>
>> I ccmailed to this list to point out this BIC commit I had to do in branch
>> before tagging (today)
> ...
>> > --- branches/KDE/4.2/kdelibs/plasma/runnercontext.h #960776:960777
>> > @@ -119,7 +119,7 @@
>> >           * to avoid unecessary processing in runners that may run for an
>> > extended * period (as measured in 10s of ms) and therefore improve the
>> > user experience. @since 4.2.3 */
>> > -        bool isValid();
>> > +        bool isValid() const;
>> >
>
> Ehhm, adding a const is binary incompatible ?
> Do you think it is allowed to commit anything which is BIC ?
> Can you do instead the following ?
>
>   bool isValid()  {return const_cast<const RunnerContext*>(this)->isValid();}
>   bool isValid() const { ... the actual implementation ...}
>
> (non-inline of course)

This method was only backported to 4.2 a week ago, so it's only BIC to
svn, not to any released version.  At least thats as I understand it.

Dan,
>
> Alex
>