branches/KDE/4.2/kdelibs/plasma [BIC]

[Aaron J. Seigo]

On Wednesday 29 April 2009, Alexander Neundorf wrote:
> On Wednesday 29 April 2009, Jacopo De Simoi wrote:
> > Hi
> >
> > I ccmailed to this list to point out this BIC commit I had to do in
> > branch before tagging (today)
>
> ...
>
> > > --- branches/KDE/4.2/kdelibs/plasma/runnercontext.h #960776:960777
> > > @@ -119,7 +119,7 @@
> > >           * to avoid unecessary processing in runners that may run for
> > > an extended * period (as measured in 10s of ms) and therefore improve
> > > the user experience. @since 4.2.3 */
> > > -        bool isValid();
> > > +        bool isValid() const;
>
> Ehhm, adding a const is binary incompatible ?
> Do you think it is allowed to commit anything which is BIC ?

isValid() was part of a backported bugfix from trunk; it wasn't in 4.2.2:

http://websvn.kde.org/tags/KDE/4.2.2/kdelibs/plasma/runnercontext.h?view=markup

Jacopo is just getting this change in before it _is_ released as part of 4.2.3 
and we can't change it. so it's BIC, but not in a released version.

and usually we don't backport API additions, but this changeset allows krunner 
to work much, much more reliably to the point we consider it a critical fix.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090429/89d6d533/attachment.sig>