branches/KDE/4.2/kdelibs/plasma [BIC]

[Andreas Pakulat]

On 29.04.09 19:26:40, Alexander Neundorf wrote:
> On Wednesday 29 April 2009, Jacopo De Simoi wrote:
> > Hi
> >
> > I ccmailed to this list to point out this BIC commit I had to do in branch
> > before tagging (today)
> ...
> > > --- branches/KDE/4.2/kdelibs/plasma/runnercontext.h #960776:960777
> > > @@ -119,7 +119,7 @@
> > >           * to avoid unecessary processing in runners that may run for an
> > > extended * period (as measured in 10s of ms) and therefore improve the
> > > user experience. @since 4.2.3 */
> > > -        bool isValid();
> > > +        bool isValid() const;
> > >
> 
> Ehhm, adding a const is binary incompatible ?

Yes, it changes the functions signature.

> Do you think it is allowed to commit anything which is BIC ?

In this case yes, as that method didn't exist in any existing release of
kdelibs. It is however BiC if the method has been backported to 4.2
branch between 4.2.2 and before his commit. Such changes are usually
only allowed to do on mondays, but next monday would've been too late.
Thats why Jacopo cc'ed the list.

Andreas

-- 
You have had a long-term stimulation relative to business.