Review Request: Fix ReadOnlyPart crash for non-local files

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/524/
-----------------------------------------------------------

(Updated 2009-04-07 12:58:02.893708)


Review request for kdelibs.


Changes
-------

This is a completely updated patch - this problem was discussed in another thread in kde-core-devel and the fix actually needs to be done in KUiServerJobTracker, as it connects its cancelation to a KJob::kill without EmitResult.


Summary
-------

As the listed bugs say, when a URL is passed to a program and its ReadOnlyPart opens it, the program crashes when closed if the transfer is stoppped before it's finished. Calling "ark www.foo.bar/baz.zip" or "okular www.foo.bar/baz.pdf" both present this behaviour.

This patch makes the registered FileCopyJob not autodelete itself when the transfer is stopped, thus making ReadOnlyPart::abortLoad not access a dead object.


This addresses bugs 186722, 186980, 187538, and 188231.
    https://bugs.kde.org/show_bug.cgi?id=186722
    https://bugs.kde.org/show_bug.cgi?id=186980
    https://bugs.kde.org/show_bug.cgi?id=187538
    https://bugs.kde.org/show_bug.cgi?id=188231


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/jobs/kuiserverjobtracker.h 950397 
  /trunk/KDE/kdelibs/kdeui/jobs/kuiserverjobtracker.cpp 950397 

Diff: http://reviewboard.kde.org/r/524/diff


Testing
-------

Both Ark and Okular stopped crashing here.


Thanks,

Raphael