Review Request: Fix ReadOnlyPart crash for non-local files

Raphael Kubo da Costa kubito at
Tue Apr 7 20:58:03 BST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-04-07 12:58:02.893708)

Review request for kdelibs.


This is a completely updated patch - this problem was discussed in another thread in kde-core-devel and the fix actually needs to be done in KUiServerJobTracker, as it connects its cancelation to a KJob::kill without EmitResult.


As the listed bugs say, when a URL is passed to a program and its ReadOnlyPart opens it, the program crashes when closed if the transfer is stoppped before it's finished. Calling "ark" or "okular" both present this behaviour.

This patch makes the registered FileCopyJob not autodelete itself when the transfer is stopped, thus making ReadOnlyPart::abortLoad not access a dead object.

This addresses bugs 186722, 186980, 187538, and 188231.

Diffs (updated)

  /trunk/KDE/kdelibs/kdeui/jobs/kuiserverjobtracker.h 950397 
  /trunk/KDE/kdelibs/kdeui/jobs/kuiserverjobtracker.cpp 950397 



Both Ark and Okular stopped crashing here.



More information about the kde-core-devel mailing list