Review Request: Fix ReadOnlyPart crash for non-local files

Aaron J. Seigo aseigo at kde.org
Mon Apr 6 16:33:28 BST 2009


On Monday 06 April 2009, Alessandro Diaferia wrote:
> As done with my patch, in the last mail i sent to the mailing list (sorry
> for duplicating) just connecting to the finished() signal solves the
> issue.. But i don't really know whether my approach is correct or not.

that's another valid approach (and so could be committed), but result should 
still be emitted according to the apidox so that should also be fixed here.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090406/c564d477/attachment.sig>


More information about the kde-core-devel mailing list