Review Request: Fix ReadOnlyPart crash for non-local files

Raphael Kubo da Costa kubito at
Tue Apr 7 22:00:07 BST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-04-07 14:00:07.661264)

Review request for kdelibs.


Final version of the patch - clean it up by using key() instead of keys() and handle the case when the KJob isn't found in the hash anymore. Approved by dfaure.


As the listed bugs say, when a URL is passed to a program and its ReadOnlyPart opens it, the program crashes when closed if the transfer is stoppped before it's finished. Calling "ark" or "okular" both present this behaviour.

This patch makes the registered FileCopyJob not autodelete itself when the transfer is stopped, thus making ReadOnlyPart::abortLoad not access a dead object.

This addresses bugs 186722, 186980, 187538, and 188231.

Diffs (updated)

  /trunk/KDE/kdelibs/kdeui/jobs/kuiserverjobtracker.h 950397 
  /trunk/KDE/kdelibs/kdeui/jobs/kuiserverjobtracker.cpp 950397 



Both Ark and Okular stopped crashing here.



More information about the kde-core-devel mailing list