[PATCH] Take care also of the KJob::finished signal in KPart - it also fixes Ark's BUG 187538

Alessandro Diaferia alediaferia at gmail.com
Mon Apr 6 17:36:34 BST 2009

2009/4/6 Kevin Ottens <ervin at kde.org>

> On Monday 6 April 2009 16:48:26 Andreas Pakulat wrote:
> > As far as I understood the problem is that the kio job doesn't call
> > emitResult in some case, but the job is being autodeleted. However the
> api
> > dox for result say its always emitted when the job is done, so there
> seems
> > to be either a misleading api doc or a broken usage of KJob in kio.
> Yep, should probably add a @see kill() or something like that. As the
> verbosity come from here. If you use kill() by default it'll kill and
> delete
> the job without emitting result.
> Regards.
> --
> Kévin 'ervin' Ottens, http://ervin.ipsquad.net
> "Ni le maître sans disciple, Ni le disciple sans maître,
> Ne font reculer l'ignorance."

And so, couldn't we make kill() emitting result() ? Or, at least apidox
should be updated and somehow connect to the job deletion in the
ReadOnlyPart class..

Alessandro Diaferia
KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090406/4a7f62d2/attachment.htm>

More information about the kde-core-devel mailing list