[REVIEW] Move KFilePreviewGenerator to kdelibs

Richard Moore richmoore44 at gmail.com
Tue Sep 23 13:14:01 BST 2008

On Tue, Sep 23, 2008 at 12:12 PM, Peter Penz <peter.penz at gmx.at> wrote:
> The sources are available at:
> http://websvn.kde.org/trunk/KDE/kdebase/apps/dolphin/src/kfilepreviewgenerator.h?revision=863845&view=markup

A few comments on the API:

KFilePreviewGenerator(AbstractViewAdapter* parent, QAbstractProxyModel* model)
This method (and the forward declaration of AbstractViewAdapter)
pollute the namespace with a class that has no K prefix and is not in
a namespace.

bool showPreview() const;
This doesn't follow the normal naming convention for bool methods.

Apart from that the API seems reasonable to me.



More information about the kde-core-devel mailing list