Review request for kio_bookmarks

Xavier Vello xavier.vello at
Wed Sep 3 19:07:59 BST 2008

> Hi,
> It looks pretty good.  I think it can be moved to kdebase.
> Few comments anyway:
> - Why are all your method virtual?
> It's bad practice because virtual function make the virtual table bigger,
> and add a redirection when calling it, so you should try to avoid using
> virtual if possible. (even if i agree that in this case, those performance
> issues are almost negligible)
> - You could add yourself as author in the KAboutData
> - it seems to me that echoHead("bookmarks:/") generate unfinished html

All issues fixed in r856753

Xavier vello

More information about the kde-core-devel mailing list