[PATCH] KDialog::groupSpacingHint()

Parker Coates parker.coates at gmail.com
Sat Oct 18 18:47:07 BST 2008


On Wed, Oct 15, 2008 at 10:54, Parker Coates <parker.coates at gmail.com> wrote:
> On Mon, Oct 6, 2008 at 02:48, Parker Coates <parker.coates at gmail.com> wrote:
>> Hello,
>>
>> The latest KDE HIG offers using a vertical space of 16 pixels as an
>> additional method of grouping logically related items in a dialog. [1]
>> Rather than have this 16 pixel value hardcoded in dozens of different
>> dialogs, I propose adding a groupSpacingHint() method to the KDialog
>> class. [2] This is a static method that returns a constant in the same
>> vein as KDialog::marginHint() and KDialog::spacingHint().
>>
>> The attached patch adds such a method. Any comments?
>>
>> Parker
>
> It's been a week.
>
> I was really hoping to get some concrete approval. Should I take the
> lack of disapproval as a sign of approval? I'd really rather not push
> my change if no one agrees that it's a good idea.

Committed.




More information about the kde-core-devel mailing list