[PATCH] KDialog::groupSpacingHint()

Friedrich W. H. Kossebau kossebau at kde.org
Fri Oct 17 17:50:24 BST 2008

Hi Parker,

Am Mittwoch, 15. Oktober 2008, um 16:54 Uhr, schrieb Parker Coates:
> On Mon, Oct 6, 2008 at 02:48, Parker Coates <parker.coates at gmail.com> wrote:
> > Hello,
> >
> > The latest KDE HIG offers using a vertical space of 16 pixels as an
> > additional method of grouping logically related items in a dialog. [1]
> > Rather than have this 16 pixel value hardcoded in dozens of different
> > dialogs, I propose adding a groupSpacingHint() method to the KDialog
> > class. [2] This is a static method that returns a constant in the same
> > vein as KDialog::marginHint() and KDialog::spacingHint().
> >
> > The attached patch adds such a method. Any comments?
> >
> > Parker
> It's been a week.
> I was really hoping to get some concrete approval. Should I take the
> lack of disapproval as a sign of approval? I'd really rather not push
> my change if no one agrees that it's a good idea.

You could help if you list a number of places where it would be used, that is 
often good reasoning :)

I agree with Luciano, that layout sizes should be rather given by points or mm 
than pixel sizes, because the other layout dominating size comes from the 
fonts (perhaps a KDE5 idea). But as KDialog::marginHint(), 
KDialog::spacingHint() and (almost) everything with QStyle are also only 
pixel based, groupSpacingHint() could stay that way for now.

Other than that I think, yes,  this would really be a useful addition.

(Next we need a KCM module for this, so the sizes can finally be adjusted to 
personal needs. ;)

Okteta - KDE 4 Hex Editor - http://utils.kde.org/projects/okteta

More information about the kde-core-devel mailing list