[PATCH] thread-safe KQueuedDialog episode 2

Sebastian Trueg trueg at kde.org
Fri Nov 28 21:54:43 GMT 2008

Well, this is a hard one. Thanks a lot for noticing all these little 
things. Looks like I am way too tired...

yet another patch version..

Johannes Sixt wrote:
> Sebastian Trueg schrieb:
>> we will get there... :)
>> new patch attached.
> Shouldn't the !queue.empty() at the end of the patch be protected by a
> QMutexLocker as well?
> -- Hannes
>> Matthias Kretz wrote:
>>> The changes all look good to me. Though I'm not sure they're enough to
>>> make it thread-safe. What about concurrent accesses to
>>> KDialogQueue::queue? One thread might be appending while the GUI
>>> thread calls pop.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kdialog-thread-safe-queued-dialogs6.diff
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081128/19a6d7f5/attachment.ksh>

More information about the kde-core-devel mailing list