[PATCH] thread-safe KQueuedDialog episode 2

Johannes Sixt j.sixt at viscovery.net
Fri Nov 28 10:06:30 GMT 2008

Sebastian Trueg schrieb:
> we will get there... :)
> new patch attached.

Shouldn't the !queue.empty() at the end of the patch be protected by a
QMutexLocker as well?

-- Hannes

> Matthias Kretz wrote:
>> The changes all look good to me. Though I'm not sure they're enough to
>> make it thread-safe. What about concurrent accesses to
>> KDialogQueue::queue? One thread might be appending while the GUI
>> thread calls pop.

More information about the kde-core-devel mailing list