[PATCH] Klipper port to KConfigXT - patch or a feature?
Dmitry Suzdalev
dimsuzkde at gmail.com
Thu Nov 27 14:26:47 GMT 2008
Hi!
I just have finished porting klipper to use KConfigXT and now I wonder if this should
be merged into trunk.
The main question is: can this be considered a feature or a kind of general patch to
extend program behavior? (btw, it might be that some current bugs are fixed by this
port - at least one for sure is)
I must say I'm perfectly OK to wait till 4.3, but this way this new port will loose
several months of testing.
Also I have plans to do some further bugfixing on klipper and if I would continue to
commit fixes in this branch that would be not so convenient as fixing them in trunk
by particular commits would be.
(instead it will be a single branch merge later which'll make use 'svn blame' harder
;))
Details:
- It works for me without crashes after port :-) Tested for a week or more of a
regular use
- It contains no i18n changes. Although I moved some amount of code from cpp files to
ui files, I tried hard to transfer GUI strings unchanged.
- It contains change to several config keys of klipperrc, but I've written a
kconfig_update script that should take care of that
Diff is attached. I'd be thankful if someone will look at it, though it's more or
less big.
What do you think about this?
4.3. target or ok to go in 4.2?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081127/ec9ef5d3/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: klipper-kconfigxt.diff.gz
Type: application/x-gzip
Size: 17892 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081127/ec9ef5d3/attachment.bin>
More information about the kde-core-devel
mailing list