kdereview exemption for PolicyKit-KDE

[Trever Fischer]

On Monday 17 November 2008 03:02:30 am Thiago Macieira wrote:
> Aaron J. Seigo wrote:
> >* It is two exectubles, one is 844 LOC and the other is 648 LOC. They
> >communicate with PolicyKit via D-Bus, and link against libkdeui (and
> > it's dependencies) and the PolicyKit libraries (e.g. the dbus
> > convenience lib)
>
Sorta. D-Bus is only used to communicate with the authenticator by saying 
"Hey! We need to make sure this person knows the password!".

PolicyKit uses an external helper (polkit-auth) set suid-root to directly read 
and write to the authentication database. The library wraps around calling the 
program. The library also uses the dbus calls to the authenticator when the 
helper says authentication is required.
> I don't see how you can write a proper event loop integration in 650 lines
> of code. Much less the integration plus the application code.
>
> So, where is the event loop integration code for the convenience lib? Or,
> another related question: why use the lib instead of QtDBus generated
> wrappers around the D-Bus calls?
Because its already in qt?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081117/a82209b1/attachment.sig>